Fix some accessibility issues #1005

Open

hannaeko wants to merge 4 commits from hannaeko/improve-accessibility into master

hannaeko commented

2023-08-30 15:12:29 -04:00

(Migrated from github.com)

Hello, I am trying to address some of the accessibility issues raised in #998, #1001, #1002 and #1003.

Changes:

replace div by main for .container element
change about page title to be "About | nitter.net"
add role, label and title for liberapay icon / link
use explicit label to link label to input (this also changed the way checkbox are styled, from a span directly following the checkbox to styling the checkbox directly)
use separate fieldsets to group inputs in preference form

Cheers,
Gaël

Hello, I am trying to address some of the accessibility issues raised in #998, #1001, #1002 and #1003. Changes: * replace div by main for .container element * change about page title to be "About | nitter.net" * add role, label and title for liberapay icon / link * use explicit label to link label to input (this also changed the way checkbox are styled, from a span directly following the checkbox to styling the checkbox directly) * use separate fieldsets to group inputs in preference form Cheers, Gaël

👍 1

untitaker commented

2023-10-07 15:10:58 -04:00

(Migrated from github.com)

this patch is now deployed on nitter.woodland.cafe -- lighthouse a11y score seems to marginally improve on tweets, so I consider that a win

this patch is now deployed on `nitter.woodland.cafe` -- lighthouse a11y score seems to marginally improve on tweets, so I consider that a win

🚀 1

This pull request has changes conflicting with the target branch.

src/nitter.nim
src/sass/index.scss
src/sass/inputs.scss
src/sass/search.scss
src/views/general.nim
src/views/preferences.nim
src/views/renderutils.nim

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Fix some accessibility issues' (#1005) from hannaeko/improve-accessibility into master

Merge commit body

Reviewed-on: https://git.merrycorps.xyz/PAS/nitter/pulls/1005

Merge pull request 'Fix some accessibility issues' (#1005) from hannaeko/improve-accessibility into master

Reviewed-on: https://git.merrycorps.xyz/PAS/nitter/pulls/1005

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin hannaeko/improve-accessibility:hannaeko/improve-accessibility

git switch hannaeko/improve-accessibility

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff hannaeko/improve-accessibility

git switch hannaeko/improve-accessibility

git rebase master

git switch master

git merge --ff-only hannaeko/improve-accessibility

git switch hannaeko/improve-accessibility

git rebase master

git switch master

git merge --no-ff hannaeko/improve-accessibility

git switch master

git merge --squash hannaeko/improve-accessibility